[ 
https://issues.apache.org/jira/browse/OFBIZ-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027590#comment-17027590
 ] 

Michael Brohl commented on OFBIZ-9465:
--------------------------------------

[~adityasharma], [~jleroux]  would this be blocking a release of the 17.12 
branch?

> Replace Inline Javascript with External Javascript 
> ---------------------------------------------------
>
>                 Key: OFBIZ-9465
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9465
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Aditya Sharma
>            Assignee: Aditya Sharma
>            Priority: Major
>             Fix For: 17.12.01
>
>         Attachments: OFBIZ-9465.patch, OFBIZ-9465.patch, OFBIZ-9465.patch, 
> OFBIZ-9465.patch, OFBIZ-9465_example.patch, OFBIZ-9465_example.patch
>
>
> As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline 
> javascript for various macros like renderLookupField, 
> makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be 
> replaced with a generic code written as external javascript. Generic 
> Javascript code should be written in OfbizUtil.js and appropriate classes or 
> identifiers should be used for applying that. Any additional data can be 
> passed with HTML 5 custom data attribute 
> (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes).
> As suggested by Jacques in  https://s.apache.org/y8P1 will introduce 
> require.js for the split javascript files in a sub-task.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to