[
https://issues.apache.org/jira/browse/OFBIZ-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028032#comment-17028032
]
ASF subversion and git services commented on OFBIZ-10753:
---------------------------------------------------------
Commit 9b9db9e5111dc5bdf3c3a2fed39e81563343d7ef in ofbiz-framework's branch
refs/heads/release17.12 from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9b9db9e ]
Improved: Improve error message page to support Theming
(OFBIZ-10753)
When OFBiz raise an error, the framework use a jsp page to display it.
I improved the error page generation to support also ftl template rendering and
by this way extend the theme engine to support to overide it
On controler.xml we can now use :
<errorpage>/error/error.jsp</errorpage>
or
<errorpage>component://common/webcommon/error/Error.ftl</errorpage>
(default configuration)
On your theme you can add your own error page :
<template>
...
<template-file widget=menu
location=component://common-theme/template/macro/HtmlMenuMacroLibrary.ftl/>
+ <template-file widget=error
location=component://common-theme/template/ErrorPage.ftl/>
</template>
The component://common/webcommon/error/Error.ftl contains the logic theming
connection and to simplify source code, all framework old error page
(error.jsp) have been removed to centralize all on this new page.
Thanks to Marine Desmarchelier for the error page design
git-svn-id:
https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1856175
13f79535-47bb-0310-9956-ffa450edef68
# Conflicts:
#
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java
# themes/common/template/ErrorPage.ftl
> Improve error message page to support Theming
> ---------------------------------------------
>
> Key: OFBIZ-10753
> URL: https://issues.apache.org/jira/browse/OFBIZ-10753
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Trunk
> Reporter: Nicolas Malin
> Assignee: Nicolas Malin
> Priority: Major
> Attachments: OFBIZ-10753.patch, Sélection_224.png
>
>
> Currently when OFBiz raise an error, we use a jsp page to display it.
> On common-controler.xml :
> {code:java}
> <errorpage>/error/error.jsp</errorpage>{code}
> This method isn't support by the theming. I propose two improvements :
> * use FlexibleLocation to resolve the error page :
> {code:java}
> <errorpage>component://common/webcommon/error/error.ftl</errorpage>{code}
> * improve theme to support the error message page
> {code:java}
> <template name="screen" type="html" content-type="UTF-8" encoding="none"
> encoder="html" compress="false">
> <template-file widget="screen"
> location="component://common-theme/template/macro/HtmlScreenMacroLibrary.ftl"/>
> <template-file widget="form"
> location="component://common-theme/template/macro/HtmlFormMacroLibrary.ftl"/>
> <template-file widget="tree"
> location="component://common-theme/template/macro/HtmlTreeMacroLibrary.ftl"/>
> <template-file widget="menu"
> location="component://common-theme/template/macro/HtmlMenuMacroLibrary.ftl"/>
> + <template-file widget="error"
> location="component://common-theme/template/ErrorPage.ftl"/>
> </template>{code}
> By the way you can define your error page by the theme in first step and we
> would use the rendering type in future to display the error no only in html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
