[ https://issues.apache.org/jira/browse/OFBIZ-10953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034591#comment-17034591 ]
Pierre Smits commented on OFBIZ-10953: -------------------------------------- Hi [~jacopoc], So you're saying that before anything is added to the BI component, the field type definitions need to be corrected for it (in line with the pre-bigdata dogma, and before paradigm shifts involving Data Lakes and Data Vaults), plus the entity engine xml file needs to be corrected accordingly? > have CurrencyDimension have a dimensionId that is based on the natural key > -------------------------------------------------------------------------- > > Key: OFBIZ-10953 > URL: https://issues.apache.org/jira/browse/OFBIZ-10953 > Project: OFBiz > Issue Type: Improvement > Components: bi > Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 > Reporter: Pierre Smits > Assignee: Pierre Smits > Priority: Major > Labels: CurrencyDimension, birt, currency, dimension, dwh > Attachments: 20200208_094840.jpg, OFBIZ-10953-BI.patch > > > Currently the record sequencer (delegator.getNextSeqId) is used to determine > the dimensionId for the CurrencyDimension. This is unnecessary as the uomId > from the UOM table can be used for currency. > It also makes it easier to set the foreign-key in fact tables by generating > it based on the date provided, than by retrieving the dimensionId based on a > retrieval through the getDimensionIdFromNaturalKey service. -- This message was sent by Atlassian Jira (v8.3.4#803005)