[ 
https://issues.apache.org/jira/browse/OFBIZ-11335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17041225#comment-17041225
 ] 

Nicolas Malin commented on OFBIZ-11335:
---------------------------------------

You right Sebastian, it's my fault, I forgot to migrate the FormFactory present 
on FindGeneric.groovy.

I fixed it on commit 0da10ea897ae0b9fc9654c8faedc6f435ec21c26

Thanks for your quick alert

> Add CommonForms as template pattern configured by theme
> -------------------------------------------------------
>
>                 Key: OFBIZ-11335
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11335
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework, themes
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Major
>             Fix For: Upcoming Branch
>
>         Attachments: Bildschirmfoto 2020-02-20 um 17.49.22.png, 
> OFBIZ-11335.patch
>
>
> Currently on OFBiz we implemented a process to define some different screen 
> and menu that can be implemented by the theming
> But for the form we have nothing. All style are hard coded on each
> {code:java}
> <grid name="ListEntities" ...
>  odd-row-style="alternate-row" default-table-style="basic-table 
> hover-bar">{code}
>  
> I propose to extend the theming implementation principle to forms element.
> To start low, I define seven form tempates :
>  * grid CommonSimpleGrid
>  * grid CommonBasicGrid
>  * form CommonSimpleList
>  * form CommonBasicList
>  * form CommonInLineEditList
>  * form CommonSimpleSingle
>  * form CommonBasicSingle
>  
> We can use its like :
> {code:java}
> <form name="LayoutDemoList" extends="CommonBasicList" 
> extends-resource="component://common/widget/CommonForms.xml"{code}
> The main difficulty raise to this task was propage the visualTheme during the 
> ModelForm intanciation, because we need to load wiget style (and some other 
> information wanted on the template) on model load in memory. 
> With the linked patch I improved form present on screen 
> [https://localhost:8443/webtools/control/WebtoolsLayoutDemo]
>  
> Finally with this we can extend style form (pagination, header, line and so 
> on ...) direclty by your theme without change the framework



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to