[ 
https://issues.apache.org/jira/browse/OFBIZ-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202610#comment-17202610
 ] 

Suraj Khurana commented on OFBIZ-11965:
---------------------------------------

Hello Vaibhav,

Thanks for providing the patch.
We are using deprecated tags currently for older services and they will be 
removed in next release. Please explore deprecated tag used in service 
definition and do the required changes in the patch.

Also, please move tickets to Patch Provided status once you have uploaded the 
complete patch, so that more reviewers can review and committers can approach 
it.

Let me know in case some more info required fromĀ  my side.

TIA.

> Improve service name as per best practices
> ------------------------------------------
>
>                 Key: OFBIZ-11965
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11965
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL PLUGINS
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Priority: Minor
>         Attachments: OFBIZ-11965-NamingConventionFix.patch
>
>
> Following service names should be corrected as per naming convention best 
> practices:
>  * SagePayPaymentAuthorisation
>  * SagePayPaymentRefund
>  * SagePayPaymentRelease
>  * SagePayPaymentVoid
>  * SetTimeZoneFromBrowser
>  * SagePayPaymentAuthentication



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to