[ 
https://issues.apache.org/jira/browse/OFBIZ-12068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255026#comment-17255026
 ] 

Jacques Le Roux commented on OFBIZ-12068:
-----------------------------------------

Hi Amit,

Your changes looks good but please add spaces around "+" at 
bq. return ServiceUtil.returnError("Sorry! No supplier available to droship 
product #"+productId+" with quantity "+dropShipQuantity+" and currency 
"+getCurrency());

There are maybe other chekstyle issues. Before creating your patch check using 
"gradlew check", TIA

> Order processing issue for dropship only products
> -------------------------------------------------
>
>                 Key: OFBIZ-12068
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12068
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Trunk
>            Reporter: Amit Gadaley
>            Assignee: Jacques Le Roux
>            Priority: Major
>         Attachments: OFBIZ-12068-1.patch, OFBIZ-12068-2.patch
>
>
> When a dropship only (or dropship on low ATP) product with no qualified 
> supplier added to shopping cart and cart converted to sales order. System 
> should return errors and should not create sales order.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to