[
https://issues.apache.org/jira/browse/OFBIZ-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300800#comment-17300800
]
Jacques Le Roux edited comment on OFBIZ-12192 at 3/13/21, 11:02 AM:
--------------------------------------------------------------------
bq. I saw that the Windows init script lacks most of the features of the shell
script (no checksum checks).
To lower maintenance, I initially kept it as minimal as possible. In this new
case checking checksums is superfluous, it's on our own repo on GH. If
something is wrong there we are screewed anyway and GH too.
bq. I'm also not sure why we download the gradlew.bat file, the shell script is
in git...?
IIRW the the gradlew.bat file depends on version. [~nmalin] [suggested to
upload it on
Bintray|https://cwiki.apache.org/confluence/display/OFBIZ/Load+new+gradle+wrapper+version+on+bintray].
I guess it's the same for the shell script. Do we have the right version
(4.5.1 instead of previously v3.2.1) in our repo, or are they compatible?
As I commented in the PowerShell script:
"\# HTTPS is not used because it gets complicated with Powershell and .Net
framework versions depending on Windows versions"
I crossed several issue handling HTTPS (using Powershell 5.0 on Win7). There
are solutions for them but it's not that easy. I'll continue later...
was (Author: jacques.le.roux):
bq. I saw that the Windows init script lacks most of the features of the shell
script (no checksum checks).
To lower maintenance, I initially kept it as minimal as possible. In this new
case checking checksums is superfluous, it's on our own repo on GH. If
something is wrong there we are screewed anyway and GH too.
bq. I'm also not sure why we download the gradlew.bat file, the shell script is
in git...?
IIRW the the gradlew.bat file depends on version. [~nmalin] [suggested to
upload it on
Bintray|https://cwiki.apache.org/confluence/display/OFBIZ/Load+new+gradle+wrapper+version+on+bintray].
I guess it's the same for the shell script. Do we have the right version
(4.5.1 instead of previously v3.2.1) in our repo, or are they compatible?
As I commented in the PowerShell script:
bq. # HTTPS is not used because it gets complicated with Powershell and .Net
framework versions depending on Windows versions
I crossed several issue (using Powershell 5.0 on Win7). There are solutions for
them but it's not that easy. I'll continue later...
> Replace Bintray by a new place to upload the Gradle Wrapper
> -----------------------------------------------------------
>
> Key: OFBIZ-12192
> URL: https://issues.apache.org/jira/browse/OFBIZ-12192
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
> Affects Versions: 18.12.01, Trunk, 17.12.06
> Reporter: Jacques Le Roux
> Assignee: Michael Brohl
> Priority: Blocker
> Fix For: Release Branch 17.12
>
>
> We got an issue with Bintray and jcenter :
> [https://markmail.org/message/hal4od7xeoig6xfw]
> The jcenter aspect is now fixed with OFBIZ-12171 (actually jcenter will allow
> download until February 1st 2022)
> With our need to upload the Gradle Wrapper we have though still an issue with
> Bintray: [https://markmail.org/message/74u6wsldx3ykzqiv]
> The problem is once we release a package the scripts at
> [https://github.com/apache/ofbiz-framework/tree/trunk/gradle] are freezed. So
> people using these scripts will not be able to download the related Gradle
> Wrapper versions.
> So we need to replace Bintray by another place to upload the different
> versions of the Gradle Wrapper. All supported OFBiz versions are concerned.
> Note: I have already put
> [https://cwiki.apache.org/confluence/display/OFBIZ/Load+new+gradle+wrapper+version+on+bintray]
> in Wiki Attic
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
