[
https://issues.apache.org/jira/browse/OFBIZ-12268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379241#comment-17379241
]
ASF subversion and git services commented on OFBIZ-12268:
---------------------------------------------------------
Commit 7792565fcfadf5328e17ee88a586072462811ff2 in ofbiz-framework's branch
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7792565 ]
Fixed: Improve js function OfbizUtil.ajaxSubmitFormUpdateAreas, some errors
don't appear (OFBIZ-12268)
After the refactoring realized on issue OFBIZ-12268, a typo has been introduce
when we scanned the presence of error during an ajax call.
The typo raised that ignore the case of an error is present as list.
The same typo is also present for event message list.
Thanks to Xin Wang to alert on this problem through issue OFBIZ-12272
> Improve js function OfbizUtil.ajaxSubmitFormUpdateAreas
> -------------------------------------------------------
>
> Key: OFBIZ-12268
> URL: https://issues.apache.org/jira/browse/OFBIZ-12268
> Project: OFBiz
> Issue Type: Sub-task
> Components: themes
> Affects Versions: Trunk
> Reporter: Nicolas Malin
> Assignee: Nicolas Malin
> Priority: Minor
> Labels: ajax, js, screen, theme
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12268.patch
>
>
> At this time the function ajaxSubmitFormUpdateAreas present on
> themes/common-theme/webapp/common/js/util/OfbizUtil.js take a form, submit it
> thought ajax and wait a success to analyse a json result for update an area
> with the cvsAreaString given on paramater.
> I propose different imrpovements :
> * refactoring some js code to centralize the analyze of json result for
> check if the call is a success or error
> * Analyze the content-type of the response if is a json continue as before,
> else take the return and update first area (useful for submit search or
> filtering form)
> * Manage the case who the ajax call failed and we inform the user
> * Add a trigger to force the modal close on submit success
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
