[
https://issues.apache.org/jira/browse/OFBIZ-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17449597#comment-17449597
]
Pierre Smits commented on OFBIZ-12405:
--------------------------------------
Merci Jacques,
{noformat}
OK, it seems we have some time to spent on this.{noformat}
Indeed it seems like that. And you appear to be glad about spending time to
prove me wrong, trivialise the issue etc. (especially when you later in your
comment: when there are much more important ones waiting...)
I respect you so much that I cannot pass the opportunity to clarify stuff
related to what your brought forward.
Please look back from where this came: linked ticket OFBIZ-12384 and PR 344. My
apologies that the description of this ticket doesn't match expectations.
{noformat}
A famous author asked this question: "What's in a name?". His answer was that
it's irrelevant* and I more than agree with that**.{noformat}
Indeed irrelevant. Both the question, and the statement.
{noformat}
What end users will see, and is important, is the translation in their
languages. We should not confuse syntax (name) and semantic (content).{noformat}
In this case, for the replacing label will eliminate confusion: syntax (name)
and semantic (content) will be in sync: CommonPayments (name/syntax) and for
English the translation (semantics) 'Payments', for French 'Payements', for
German 'Zahlungen', for Dutch 'Betalingen'. Not only confusion elimination for
users, but also for contributors.
{noformat}
*What I mean is end users will never see the name of the label
(AccountingApplications). Only developpers will see it and that does not count
much. {noformat}
Thank you that you believe that what counts for (is important to) any other
contributor is something that you feel can/must define.
{noformat}
This menu-item does not show when an invoice has been paid (ie all payments are
applied to the invoice). It shows when no payments are applied to the
invoice.{noformat}
Again consider where this came from (originating ticket and PR). With current
demo data no, (eliminating that gap is another ticket, I guess). It will show
(to both users with VIEW Permissions' and with more permissions, like
CREATE/UPDATE):
# multiple partial payments of the invoice (if paid in portions) or
# single payment (in full) of the invoice with the date when the payment was
made.
You can test drive this yourself in
[https://demo-trunk.ofbiz.apache.org/accounting/control/editInvoiceApplications?invoiceId=demo10001]
(as a user with CREATE/UPDATE privileges) by selecting payment 8000 and
associate it with the invoice by clicking the trigger at the end of the line
item. When subsequently logging in as a user with only VIEW permissions, and
accessing the same uri, you will see the payments that pay for this invoice.
{noformat}
a screen which title is: "Assign Payment to This Invoice".{noformat}
I did a search/find action on the trunk branch. Could not find any screen
definition that has a label which has that English translation. It seems the
label for this translation (AccountingAssignPaymentToInvoice) is not used in
any menu-item, or other trigger in any screen definition in InvoiceScreens.xml.
Not even in a screen definition in PaymentScreens.xml. (removal from the code
base should be address in another ticket).
{noformat}
a screen which title is: "Possible payments to apply [payer] sent from
[recipient]" (combination of AccountingListPaymentsNotYetApplied and
AccountingPaymentSentForm labels){noformat}
Ahh. the sub screen in EditInvoiceApplications screen definition in
InvoiceScreens.xml. Again, consider where this ticket is coming from. This sub
section is not intended for users with only VIEW privileges.
{noformat}
For AccountingApplicationSuccess, we need 1st to agree (or definitely not)
about what to do about AccountingApplications before speaking again about
that...Don't expect more comments on this from me...{noformat}
Same here. Unless... you or any other contributor believes it becomes relevant
(again) to this ticket at a later date/time. Who knows what happens then. :)
{noformat}
* "That which we call a rose by any other name would smell just as sweet."
** For the fun: my name is "Le Roux", it means "The Redhead", but my hairs are
black. Not only names (syntax) can be irrelevant but sometimes wrong. That's
not a problem, what's count is their content (semantic), here me {noformat}
Yeah... What to say about that... I like the attempt to be funny, inclusive and
considerate and such, so... thank you!
Remember what I said recently about breaking up OFBIZ-12384 and PR 344: before
long a(other) contributor will come along and will start to project that any
and all new ticket(s) (related to the original ticket and PR, as you desired in
comments in that ticket and elsewhere) is trivial and insignificant? Remember
that?
> Rename invoiceApplications menu-item label to Payments
> ------------------------------------------------------
>
> Key: OFBIZ-12405
> URL: https://issues.apache.org/jira/browse/OFBIZ-12405
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
> Affects Versions: Trunk
> Reporter: Pierre Smits
> Assignee: Pierre Smits
> Priority: Major
> Labels: invoice, usability
>
> Application(s) is generic (also used within contexts elsewhere) in OFBiz.
> Users have a better perception of context when looking at a menu-item
> Payments in the screen of an invoice, than seeing Applications.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
