[
https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467941#comment-17467941
]
Marco RODRIGUES commented on OFBIZ-9498:
----------------------------------------
hi [~pierresmits],
Your reasoning is correct if it was just a question of improving the existing
PR by adding code. But the aim is ti replace the way the
UtilProperties.getEnvironmentProperty function integrates with the application.
Here are the two issues for which I advise against accepting this PR as is:
1. The function must be replaced/renamed, or managed in another class because
it does not respect the definition of the Utilproperties class: "Utilities for
working with properties files"
(https://ci.apache.org/projects/ofbiz/site/stable/javadocs/org/apache/ofbiz/base/util/UtilProperties.html)
At least because environment variables are not "properties files" in the way
they are handled here.
2. The direct use of the UtilProperties.getEnvironmentProperty function in the
java code for calling variables is not the better way. It is specific to
environment variables, and therefore blocks or complicates any evolution.
Better to start on another function / class which would manage which would
frame the call to variables and manage mergers and overloads.
But we still need to make a quick inventory of what already exists in order to
be able to offer a quick implementation that does not block us.
Hoping to be clear and remaining available for any questions.
P.S. Sorry for not giving these details before, but since I haven't had
detailed feedback and any other alternative implementation examples, I didn't
think it would be useful to pollute this thread with Nereid code-specific
explanations. but you are right to have all explanations.
This thread has been relaunched, first of all, to share the contributions in
order to move forward on a solution. Not to push this PR as it is.
So if you can retrieve others implementation of this issue to enrich the
reflexion , they are welcomed !
Thanks for your feedback.
> Improve DevOps using environment variable configuration
> -------------------------------------------------------
>
> Key: OFBIZ-9498
> URL: https://issues.apache.org/jira/browse/OFBIZ-9498
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk
> Reporter: Gil Portenseigne
> Assignee: Gil Portenseigne
> Priority: Minor
> Attachments: OFBIZ-9498.patch
>
>
> Discussed in thread : https://s.apache.org/Mh3q
> This Jira will present the improvment proposal giving a way to configure
> OFBiz using environment variable.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
