The GitHub Actions job "CodeQL" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
f9d79d4ef8ee161aad912654376683b96d19e4d6 / Jacques Le Roux 
<jacques.le.r...@les7arts.com>
Fixed: Fix some bugs SpotBugs reports (OFBIZ-12386)

Fixes the error below that returns a HTTP 500 code when "cookies" is null

Sep 28, 2022 1:57:20 PM org.apache.catalina.core.StandardWrapperValve invoke
SEVERE: Servlet.service() for servlet [ControlServlet] in context with path 
[/catalog] threw exception
java.lang.ArrayStoreException: javax.servlet.http.Cookie
at java.base/java.util.stream.Nodes$FixedNodeBuilder.accept(Nodes.java:1230)
at 
java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
at 
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
at 
java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
at 
java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:550)
at 
java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260)
at 
java.base/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:517)
at org.apache.ofbiz.webapp.stats.VisitHandler.getVisitor(VisitHandler.java:231)

It breaks OFBiz when Debug.verbose is on and in serverstats.properties these
defaults are used:
# Specify whether to use the visit history feature or not
stats.persist.visit=true
stats.persist.visitor=true

I found this error in stable demo console log after the demo was broken.

I must say I'm not very proud of what I did with
https://github.com/apache/ofbiz-framework/commit/f126bae
It was obviously wrong :)

Conflicts handled by hand in VisitHandler.java

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3145569103

With regards,
GitHub Actions via GitBox

Reply via email to