[ https://issues.apache.org/jira/browse/OFBIZ-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724195#comment-17724195 ]
ASF subversion and git services commented on OFBIZ-10477: --------------------------------------------------------- Commit 388139fe4cc6a8c81489f6ceac379a6cda4f8b0d in ofbiz-framework's branch refs/heads/release22.01 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=388139fe4c ] Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477) (OFBIZ-10480) Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s conversation, this fixes SAFE util methods being transformed to private when obviously they should be public Thanks: Michael for spotting, reporting and confirming it's OK > Parent ticket for reducing scope of variables and methods > --------------------------------------------------------- > > Key: OFBIZ-10477 > URL: https://issues.apache.org/jira/browse/OFBIZ-10477 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: 22.01.01, Upcoming Branch > Reporter: Pradhan Yash Sharma > Assignee: Jacques Le Roux > Priority: Minor > Fix For: Upcoming Branch > > > *Downsize Accessibility Scope* > I've tried to downsize accessibility scope of classes, interfaces, abstract > class, declared member variables, enumerations, methods, and constructors to > as minimum as possible as per OFBIz current implementation, still there is a > lot of scope for improvement but it would require changes at the granular > level. I've used > [this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] > as my reference point. example: > > {code:java} > public void noteKeyRemoval(UtilCache<K, V> cache, K key, V oldValue);{code} > {code:java} > void noteKeyRemoval(UtilCache<K, V> cache, K key, V oldValue); {code} > As per the current implementation, I will try to give minimum scope > furthermore can be enhanced -- This message was sent by Atlassian Jira (v8.20.10#820010)