[
https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793201#comment-17793201
]
Jacques Le Roux edited comment on OFBIZ-12868 at 12/5/23 9:41 AM:
------------------------------------------------------------------
.bq Also I have still to handle the branches changes in pulPluginSource
I finally decided to not use Gradle but only shell scripts for 3 reasons:
* To be able to change the current directory an Exec task must be used where
"workingDir " is accessible. And it comes with some complications I crossed
* The pullPluginSource and pullAllPluginsSource tasks come also with some
complications and use dependsOn which is no longer recommended to use most of
the time:
[https://melix.github.io/blog/2021/10/gradle-quickie-dependson.html#_conclusion]
* Last but not least, for these 2 tasks we don't need to use Gradle which is
much slower than directly using shell scripts (mins vs seconds)
.bq Note: I have no tested bash scripts, they should be OK, the differences are
minimal, just passing parameters.
Actually the 2 new dos/bat scripts ( [^pullAllPlugins.bat] and
[^pullAPlugin.bat] ) have no bash scripts correspondant
They are quite simple and can be used one after the other in any order.
I prefer to let the work for another person :)
{color:#FF8B00}It should be pushed before January 8, 2024...{color}
Here are also the changes in main build.gradle: [^OFBIZ-12868-svncheckout.patch]
was (Author: jacques.le.roux):
{quote}Also I have still to handle the branches changes in pulPluginSource
{quote}
I finally decided to not use Gradle but only shell scripts for 3 reasons:
* To be able to change the current directory an Exec task must be used where
"workingDir " is accessible. And it comes with some complications I crossed
* The pullPluginSource and pullAllPluginsSource tasks come also with some
complications and use dependsOn which is no longer recommended to use most of
the time:
[https://melix.github.io/blog/2021/10/gradle-quickie-dependson.html#_conclusion]
* Last but not least, for these 2 tasks we don't need to use Gradle which is
much slower than directly using shell scripts (mins vs seconds)
{quote}Note: I have no tested bash scripts, they should be OK, the differences
are minimal, just passing parameters.
{quote}
Actually the 2 new dos/bat scripts ( [^pullAllPlugins.bat] and
[^pullAPlugin.bat] ) have no bash scripts correspondant
They are quite simple and can be used one after the other in any order.
I prefer to let the work for another person :) It should be pushed before
January 8, 2024...
Here are also the changes in main build.gradle: [^OFBIZ-12868-svncheckout.patch]
> Replace SvnCheckout in Gradle
> -----------------------------
>
> Key: OFBIZ-12868
> URL: https://issues.apache.org/jira/browse/OFBIZ-12868
> Project: OFBiz
> Issue Type: Task
> Components: GitHub, Gradle
> Affects Versions: 22.01.01, Upcoming Branch, 18.12.10
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Major
> Attachments: OFBIZ-12868-svncheckout.patch, build.gradle.notworking,
> gitClonePlugins.bat, gitClonePlugins.patch, gitClonePlugins.sh,
> pullAPlugin.bat, pullAllPlugins.bat, pullPluginSource.bat, pullPluginSource.sh
>
>
> As mentionned in
> https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy
> the SvnCheckout Gradle plugin will not be usable after January 8, 2024.
> So we need a replacement and it's clearly suggested by GitHub in the link
> above
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
