[ https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814109#comment-17814109 ]
Jacques Le Roux edited comment on OFBIZ-12888 at 2/4/24 4:18 PM: ----------------------------------------------------------------- I have no problems building with Eclipse 2023-06 on Win7 nor 2023-03 on Ubuntu 20.04. I vaguely remeber having seen quite a perf difference but that was on Win7 and we know NFTS is not the better file manager. Maybe I checked on GH too, not sure. And I don't remember having tested after a clean, maybe the reason indeed. So it's OK with me as long as it's OK with [~danwatford] was (Author: jacques.le.roux): I have no problems building with Eclipse 2023-06 on Win7 nor 2023-06 on Ubuntu 20.04. I vaguely remeber having seen quite a perf difference but that was on Win7 and we know NFTS is not the better file manager. Maybe I checked on GH too, not sure. And I don't remember having tested after a clean, maybe the reason indeed. So it's OK with me as long as it's OK with [~danwatford] > Gradle eclipse target produces duplicate build path entries in .classpath > ------------------------------------------------------------------------- > > Key: OFBIZ-12888 > URL: https://issues.apache.org/jira/browse/OFBIZ-12888 > Project: OFBiz > Issue Type: Bug > Components: Gradle > Affects Versions: Upcoming Branch > Reporter: Michael Brohl > Assignee: Michael Brohl > Priority: Major > > I'm currently working on a solution for this. > Maybe someone can explain why we use the GroovyScripts source set for the > codenarc checks in the pre-push hook: > > {code:java} > gitHooks { > hooks = ['pre-push': 'checkstyleMain codenarcGroovyScripts'] > } > {code} > That target seems to be automatically defined through the source set > definition for groovyScripts. > If I remove that source set and the following task configuration: > > {code:java} > tasks.named('compileGroovyScriptsGroovy') { > // We don't want to build groovyScripts as they should be considered as > standalone elements executed in > // isolation by ofbiz. Building them will result in numerous error due to > duplicated classes. > enabled = false > } > {code} > > And change the git hooks to > > {code:java} > } > gitHooks { > hooks = ['pre-push': 'checkstyleMain codenarcMain codenarcTest'] > } > {code} > > (which is accoring to the pre-push hook definition in .git/hooks/pre-push) > everything seems to work fine, tests are working and the codenarc Main and > Test reports are build. > I provide a PR for it. -- This message was sent by Atlassian Jira (v8.20.10#820010)