danwatford opened a new pull request, #722: URL: https://github.com/apache/ofbiz-framework/pull/722
Part of the OFBIZ-11456 refactoring effort. Removed unused renderDropDownField FTL macro attributes from the various FormMacroLibrary.ftl files. Synchronised the attribute lists among the files and changed some attributes to have default values and/or use non-string types. Moved logic used to construct the call to the renderDropDownField macro into RenderableFtlFormElementsBuilder where the logic now constructs a RenderableFtlMacroCall object rather than a long string. Use of RenderableFtlMacroCall means objects, rather than string representations of objects, are passed to FTL. This has allowed removal of workarounds introduced in OFBIZ-6504 to escape characters passed to Freemarker in macro attributes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org