[
https://issues.apache.org/jira/browse/OFBIZ-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837407#comment-17837407
]
ASF subversion and git services commented on OFBIZ-13025:
---------------------------------------------------------
Commit 1f5ac53afc3feb8b671b1c9df27fef317dce7156 in ofbiz-framework's branch
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1f5ac53afc ]
Improved: Reduce code complexity re marketing menus (OFBIZ-13025) (#757)
* Improved: Reduce code complexity re marketing menus (OFBIZ-13025)
Currently, we have in the marketing component/application - besides the main
menus (in MarketingMenus.xml, menus for specific screens/functions in:
* ContactListMenus.xml: 2 menus, with resp. 5 and 2 menu-items; used in
ContactListScreens.xml
* DataSourcesMenus.xml: 1 menu, with 2 menu-items; used in DataSourceScreens.xml
* MarketingCampaignMenus.xml: 1 menu, with 2 menu-items; used in
MarketingCampaignScreens.xml
*SegmentMenus.xml: 1 menu, with 4 menu-items; used in
SegmentScreens.xml*TrackingCodeMenus.xml: 1 menu, with 4 menu-items, used in
TrackingCodeScreens.xml
We should move the menus in those menu xml file to MarketingMenus.xml (and
adjust the location references in the appropriate screens) to reduce code
complexity and enhance the developer experience.
modified:
* MarketingMenus.xml: added menus, ContactListTabBar, ContactListComBar,
DataSourceTabBar, MarketingCampaignTabBar, SegmentGroupTabBar,
TrackingCodeTabBar
* CommonScreens.xml, ContactListScreens,xml, DataSoourceScreen.xml,
MarketingCampaignScreens.xml, SegmentScreens.xml, TrackingCodeScreens.xml:
changed menu location from hardcoded to parameterized
deleted: ContactListMenus.xml, DataSourceMenus.xml, MarketingCampaignMenus.xml,
SegmentMenus.xml, TrackingCodeMenus.xml
* correcting typo
> Reduce code complexity re marketing menus
> -----------------------------------------
>
> Key: OFBIZ-13025
> URL: https://issues.apache.org/jira/browse/OFBIZ-13025
> Project: OFBiz
> Issue Type: Sub-task
> Components: marketing/marketing
> Reporter: Pierre Smits
> Priority: Major
>
> Currently, we have in the marketing component/application - besides the main
> menus (in MarketingMenus.xml, menus for specific screens/functions in:
> * ContactListMenus.xml: 2 menus, with resp. 5 and 2 menu-items; used in
> ContactListScreens.xml
> * DataSourcesMenus.xml: 1 menu, with 2 menu-items; used in
> DataSourceScreens.xml
> * MarketingCampaignMenus.xml: 1 menu, with 2 menu-items; used in
> MarketingCampaignScreens.xml
> * SegmentMenus.xml: 1 menu, with 4 menu-items; used in SegmentScreens.xml
> * TrackingCodeMenus.xml: 1 menu, with 4 menu-items, used in
> TrackingCodeScreens.xml
> We should move the menus in those menu xml file to MarketingMenus.xml (and
> adjust the location references in the appropriate screens) to reduce code
> complexity and enhance the developer experience.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
