The GitHub Actions job "CodeQL" on ofbiz-framework.git has succeeded.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
c2cb522b54a73f3ea596ab4c289a067eac08ad55 / Jacques Le Roux 
<jacques.le.r...@les7arts.com>
Improved: Ofbiz performance issue with ThemeFactory (OFBIZ-)

If there are many products with images (images stored in the plugin or theme),
the ThemeFactory blocks the frontend until all files are processed.

The problem is initiated in the following lines of code in ThemeFactory.java:

List<File> xmlThemes = FileUtil.findXmlFiles(themeFolderPath,
null, "theme", "widget-theme.xsd");
List<File> xmlPluginThemes = FileUtil.findXmlFiles(pluginsFolderPath,
null, "theme", "widget-theme.xsd");

I think the search path should be restricted to the "widget" folder of the
respective plugins/themes, as the theme.xml file should be located there.

Thanks: Ingo Wolfmayr

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/9550490512

With regards,
GitHub Actions via GitBox

Reply via email to