[ https://issues.apache.org/jira/browse/OFBIZ-12639 ]


    Jacques Le Roux deleted comment on OFBIZ-12639:
    -----------------------------------------

was (Author: jira-bot):
Commit 90d557844f5c7dccb328f996f444d9eab021f50a in ofbiz-framework's branch 
refs/heads/trunk from Groza Danut
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=90d557844f ]

Improved: Geo data for Romania; the 42 counties (#835)

* Fixed: Error when uploading image because of line length (OFBIZ-12639)

For image files isValidFile should not checkMaxLinesLength, since that
was created to check text files. Image validation is done by
isValidImageFile

Thanks: Ingo Wolfmayr and Jacques Le Roux for the work so far in
(OFBIZ-12639)

* Improved: Geo data for Romania; the 42 counties

> Upload image size issue
> -----------------------
>
>                 Key: OFBIZ-12639
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12639
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product/catalog
>    Affects Versions: Upcoming Branch
>            Reporter: Ingo Wolfmayr
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: 18.12.17
>
>         Attachments: 40000054.png, RerenderPatch_notready.patch, test.jpeg
>
>
> I tied to uploaded an Image > 3MB and it fails as the line length > 10000
> Does this security check make sense for images? Attached you will find the 
> image.
> Additional to that, the security message is missleading: For security reason 
> only valid files of supported image formats...
> Responsible code can be found in: SecuredUploads.java (line 205) & 
> DataServices.java (line 216)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to