[
https://issues.apache.org/jira/browse/OFBIZ-10924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909475#comment-17909475
]
Jacques Le Roux commented on OFBIZ-10924:
-----------------------------------------
I thought Gradle dependencies order had no importance. It seems though it
depends on OS.
With the last commit for this Jira, here is the build result I get locally on
Win7:
{noFormat}
C:\projectsASF\Git\ofbiz-framework>gradlew --no-daemon
To honour the JVM settings for this build a single-use Daemon process will be
forked. For more on this, please refer to
https://docs.gradle.org/8.8/userguide/gradle_daemon.html#sec:disabling_the_daemon
in the Gradle documentation.
Daemon will be stopped at the end of the build
> Task :buildSrc:extractPluginRequests UP-TO-DATE
> Task :buildSrc:generatePluginAdapters UP-TO-DATE
> Task :buildSrc:compileJava UP-TO-DATE
> Task :buildSrc:compileGroovy NO-SOURCE
> Task :buildSrc:compileGroovyPlugins UP-TO-DATE
> Task :buildSrc:pluginDescriptors UP-TO-DATE
> Task :buildSrc:processResources UP-TO-DATE
> Task :buildSrc:classes UP-TO-DATE
> Task :buildSrc:jar UP-TO-DATE
> Task :plugins:example:nodeSetup UP-TO-DATE
> Task :plugins:example:npmSetup SKIPPED
> Task :plugins:example:npmInstall NO-SOURCE
> Task :plugins:projectmgr:nodeSetup UP-TO-DATE
> Task :plugins:projectmgr:npmSetup SKIPPED
> Task :themes:common-theme:nodeSetup UP-TO-DATE
> Task :themes:common-theme:npmSetup SKIPPED
> Task :plugins:projectmgr:npmInstall UP-TO-DATE
> Task :compileJava UP-TO-DATE
> Task :themes:common-theme:npmInstall
npm WARN read-shrinkwrap This version of npm is compatible with
lockfileVersion@1, but package-lock.json was generated for lockfileVersion@3.
I'll try to do my best with it!
audited 13 packages in 0.404s
found 0 vulnerabilities
> Task :compileGroovy
> Task :processResources
> Task :classes
> Task :jar
> Task :compileTestJava
> Task :compileTestGroovy
> Task :processTestResources
> Task :testClasses
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader
classes because bootstrap classpath has been appended
> Task :test
Deprecated Gradle features were used in this build, making it incompatible with
Gradle 9.0.
You can use '--warning-mode all' to show the individual deprecation warnings
and determine if they come from your own scripts or plugins.
For more on this, please refer to
https://docs.gradle.org/8.8/userguide/command_line_interface.html#sec:command_line_warnings
in the Gradle documentation.
BUILD SUCCESSFUL in 3m
20 actionable tasks: 8 executed, 12 up-to-date
C:\projectsASF\Git\ofbiz-framework>
{noFormat}
The result with GH actions:
https://github.com/apache/ofbiz-framework/actions/runs/12588059205
And the result on BuildBot:
{noFormat}
> Task :compileJava
/home/buildslave/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-api/2.24.2/daf49ee71f2664c3ff57412e4b43061e61a28596/log4j-api-2.24.2.jar(/org/apache/logging/log4j/Level.class):
warning: Cannot find annotation method 'value()' in type 'BaselineIgnore':
class file for aQute.bnd.annotation.baseline.BaselineIgnore not found
/home/buildslave/slave/ofbizTrunkFramework/build/framework/base/src/main/java/org/apache/ofbiz/base/log4j/OFBizDynamicThresholdFilter.java:153:
warning: [deprecation] rawContextData() in ContextDataInjector has been
deprecated
return injector.rawContextData();
^
/home/buildslave/slave/ofbizTrunkFramework/build/framework/common/src/main/java/org/apache/ofbiz/common/authentication/AuthHelper.java:132:
warning: [removal] AccessController in java.security has been deprecated and
marked for removal
return AccessController.doPrivileged(
^
/home/buildslave/slave/ofbizTrunkFramework/build/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlFilter.java:73:
error: ControlFilter is not abstract and does not override abstract method
destroy() in Filter
public class ControlFilter extends HttpFilter {
^
1 error
3 warnings
{noFormat}
Also on GH, the "Build and push docker images" and CodeQL actions fail.
So I revert a last time and forget this idea of alphabetically ordering the
dependencies.
> Have library dependencies moved to a dependencies.gradle file
> -------------------------------------------------------------
>
> Key: OFBIZ-10924
> URL: https://issues.apache.org/jira/browse/OFBIZ-10924
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Trunk, Upcoming Branch
> Reporter: Pierre Smits
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: Image1.png, OFBIZ-10924-started.patch
>
>
> Currently the libraries needed by ofbiz are defined in the build.gradle file.
> These should reside in a separate dependencies.gradle file that is referenced
> in the build.gradle file, like the common.gradle. As is common practice in
> other projects/solutions that work with dependencies on external libraries.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
