[
https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18028813#comment-18028813
]
ASF subversion and git services commented on OFBIZ-11167:
---------------------------------------------------------
Commit e3c8dc485920a25b80545e6e3c666b528a67521d in ofbiz-plugins's branch
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=e3c8dc485 ]
Implemented: Fix all codenarc violation (OFBIZ-13228) (#137)
After implementation of codenarc OFBIZ-11167 we let some error due to the huge
work to fix them.
We currently allow 4384 violations (410 lvl2 and 3974 lvl3) on framework and
plugins
To know if we didn't introduce any new violation, we need to add all plugins or
check the current framework violation to adapt our locale code.
To simplify the quality development, we suggest to set allow violation to 0.
> Use Codenarc to test Groovy code
> --------------------------------
>
> Key: OFBIZ-11167
> URL: https://issues.apache.org/jira/browse/OFBIZ-11167
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
> Reporter: Jacques Le Roux
> Assignee: Gil Portenseigne
> Priority: Minor
> Fix For: Upcoming Branch, 22.01.01
>
> Attachments: OFBIZ-11167.patch, main.html, test.html
>
>
> Thread of community discussion about the rules to implement :
> https://www.mail-archive.com/search?l=dev%40ofbiz.apache.org&q=subject:%22Codenarc+integration%2C+rules+to+use.%22&o=newest&f=1
>
> Now that we use Groovy more and more, I think we should really have a look a
> Codenarc
> [https://docs.gradle.org/current/userguide/codenarc_plugin.html]
> We already discussed it at [https://markmail.org/message/uigcpnxqgizhd2oi]
> and [https://markmail.org/message/rp6njoiohkkiodbe]
> We know it's a crucial task but not an easy but rather a long term one
> Here are some interesting links (before I delete my FF tabs group about it)
> [http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html]
> [http://codenarc.sourceforge.net/codenarc-creating-ruleset.html]
> [https://github.com/gradle/gradle/tree/master/config]
> [https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s]
> [https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
