JacquesLeRoux commented on PR #913: URL: https://github.com/apache/ofbiz-framework/pull/913#issuecomment-3382068674
The issue is at ObjectTypeTests::simpleTypeOrObjectConvertTest L128 https://github.com/apache/ofbiz-framework/blob/7dba6ac5d87783c1209e84189d1d57996b82737e/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java#L128 The wanted argument is 12,345.67. At least on a French PC the value is 12 345,67. I did not test with another language. So, in this specific case, the problems are the decimal and thousands separator https://en.wikipedia.org/wiki/Decimal_separator#Digit_grouping I'm not sure, but since it's only a test, maybe it's easier to force separators value, say the English ones ("," and ".') and modify the calculated value to correspond to "wanted". Adapting the "wanted" values upstream in function of local language, eg at https://github.com/apache/ofbiz-framework/blob/7dba6ac5d87783c1209e84189d1d57996b82737e/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java#L496 https://github.com/apache/ofbiz-framework/blob/7dba6ac5d87783c1209e84189d1d57996b82737e/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java#L497 would be another solution. I did not change nor tested anything yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
