ieugen commented on PR #917: URL: https://github.com/apache/ofbiz-framework/pull/917#issuecomment-3493565728
@gtchaboussie : thanks for the contribution. I think you are also trying to increase the java source level - which might not be in scope right now. The important part is that OFBiz can be built using JDK-21. I don't believe it means we need to increase source level to 21 so only JDK-21+ can build OFBiz. I think the source level/version can stay on 17 and have OFBiz build with JDK17 and JDK21 The build fails right now because the CI server uses only JDK-17. It would be great to have OFBiz tested with multiple JDK versions at once (JDK build matrix) - but some other time. Regarding source level increase, it might be a good thing to do as well. looking at https://docs.oracle.com/en/java/javase/21/language/java-language-changes-summary.html , the only language changes that are new from 17->21 are: > [Record Patterns](https://docs.oracle.com/en/java/javase/21/language/record-patterns.html#GUID-7623D3AD-4141-4914-A384-60C65BD0C010) ([JEP 440)](https://openjdk.org/jeps/440) > [Pattern Matching for switch Expressions and Statements](https://docs.oracle.com/en/java/javase/21/language/pattern-matching-switch.html#GUID-E69EEA63-E204-41B4-AA7F-D58B26A3B232) ([JEP 441)](https://openjdk.org/jeps/441) Not sure if those are enough to warrant a source level increase. Should ask on ML. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
