[
https://issues.apache.org/jira/browse/OFBIZ-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18041224#comment-18041224
]
ASF subversion and git services commented on OFBIZ-13318:
---------------------------------------------------------
Commit 45f6a3e2477dbeef995785ab35b1de888e0d6834 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=45f6a3e247 ]
Improved: Incorrect comparison of Bigdecimals in ShoppingCart (OFBIZ-13318)
ShoppingCart::ensureItemsQuantity line 948
Bigdecimal are compared with !=
It means memory addresses are compared - was it intentional?
jleroux: actually ShoppingCart::ensureItemsQuantity is quite old (pre Apache,
so before 2006) and not used at all. So this simply removes it. No backport
needed, simple cleaning.
Thanks: Dmitriy Kryukov
> Incorrect comparison of Bigdecimals in ShoppingCart
> ---------------------------------------------------
>
> Key: OFBIZ-13318
> URL: https://issues.apache.org/jira/browse/OFBIZ-13318
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: Upcoming Branch
> Reporter: Dmitriy Kryukov
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
>
> Line 948
> Bigdecimal are compared with !=
> It means memory addresses are compared - was it intentional?
> I'm going to provide a PR
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
