[
https://issues.apache.org/jira/browse/OFBIZ-13311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18050424#comment-18050424
]
ASF subversion and git services commented on OFBIZ-13311:
---------------------------------------------------------
Commit ffdda02834948c51bc0434642f0715960e59f099 in ofbiz-framework's branch
refs/heads/trunk from Gaetan
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ffdda02834 ]
Improved: Rewrites the test class UtilCacheTest (OFBIZ-13311)
Rewrote the UtilCacheTests to a more readable fashion, with tools in a
dedicated class.
Also removes the GenericTestCaseBase, that was used only in the
UtilCacheTest.
Deleted a part of the testExpire test method, that was based on the
useAllMemory method, which is highly OS or hardware dependant making
unit test dependant as well.
Thanks: Nicolas for the help in analyzing and Jacopo and Jacques for the review.
> Rewriting the UtilCacheTests
> ----------------------------
>
> Key: OFBIZ-13311
> URL: https://issues.apache.org/jira/browse/OFBIZ-13311
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/base
> Affects Versions: Upcoming Branch
> Reporter: Gaetan Chaboussie
> Assignee: Gaetan Chaboussie
> Priority: Minor
> Labels: pull-request-available
> Attachments: OFBIZ-13311.patch
>
>
> The UtilCacheTest class was written 15 years ago, and has barely been updated
> since.
> It's very low level, so sensitive to modify, and may require attentive review.
> But these tests are quite hard to read, so i offer to, if not rewrite, at
> least try to explicit make the tests more readable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
