pjfanning commented on PR #146: URL: https://github.com/apache/incubator-pekko-connectors/pull/146#issuecomment-1584155756
> So I just checked the code and using a mutable queue to get around this problem is fine since its internal however there is one thing I noticed, can we change `private var buffer = Queue.empty[ByteString]` to a `val` (since there is no reason for it to be a var, we are not overriding the reference since we are using a mutable collection). There is a 2nd place where the queue is recreated. I can see if I can clear the original queue instead of resetting the var. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
