mdedetrich commented on code in PR #148:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/148#discussion_r1286791961
##########
gradle-plugin/build.gradle:
##########
@@ -81,6 +82,16 @@ nexusPublishing {
}
}
+Boolean isReleaseVersion = !version.toString().endsWith("SNAPSHOT")
+
+signing {
+ setRequired({
+ isReleaseVersion && gradle.taskGraph.hasTask("publish")
+ })
+ useGpgCmd()
Review Comment:
Gradle will use JVM signing by default, `useGpgCmd()` is set because people
such as myself have their signing key stored on a key device (i.e. YubiKey)
which doesn't work with JVM signing.
Its also consistent with sbt-gpg (which also uses gpg).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
