Roiocam commented on code in PR #94:
URL: https://github.com/apache/incubator-pekko/pull/94#discussion_r1365782961
##########
actor/src/main/scala/org/apache/pekko/serialization/Serialization.scala:
##########
@@ -466,8 +462,12 @@ class Serialization(val system: ExtendedActorSystem)
extends Extension {
}
}
+ @nowarn("msg=deprecated")
private def warnUnexpectedNonPekkoSerializer(clazz: Class[_], ser:
Serializer): Boolean = {
- if (clazz.getName.startsWith("org.apache.pekko.") &&
!ser.getClass.getName.startsWith("org.apache.pekko.")) {
+ import pekko.util.ccompat.JavaConverters._
+ if (clazz.getName.startsWith("org.apache.pekko.") &&
!ser.getClass.getName.startsWith("org.apache.pekko.") &&
+
!system.settings.config.getStringList("pekko.actor.warn-non-pekko-serializer-allow-list").asScala.toSet.contains(
Review Comment:
this line did't use too many feature of scala, maybe it doesn't need to
convert to scala and Set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
