pjfanning commented on code in PR #205:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/205#discussion_r1437168273
##########
interop-tests/src/test/scala/org/apache/pekko/grpc/interop/PekkoGrpcScalaClientTester.scala:
##########
@@ -41,21 +41,29 @@ import scala.util.control.NoStackTrace
* The same implementation is also be found as part of the 'scripted' tests at
*
/sbt-plugin/src/sbt-test/gen-scala-server/00-interop/src/test/scala/org/apache/pekko/grpc/PekkoGrpcClientTester.scala
*/
-class PekkoGrpcScalaClientTester(val settings: Settings, backend:
String)(implicit system: ActorSystem)
- extends ClientTester {
+class PekkoGrpcScalaClientTester(val settings: Settings, backend: String,
testWithSslContext: Boolean)(
Review Comment:
When we have a use case for creating the SSL context outside - we can change
then. Seems bad to overengineer test code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
