mdedetrich commented on code in PR #981:
URL: https://github.com/apache/incubator-pekko/pull/981#discussion_r1462538773
##########
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/StreamOfStreams.scala:
##########
@@ -614,14 +607,31 @@ import pekko.util.ccompat.JavaConverters._
override def onDownstreamFinish(cause: Throwable): Unit = {
substreamCancelled = true
- if (isClosed(in) || propagateSubstreamCancel(cause)) {
- cancelStage(cause)
- } else {
- // Start draining
- if (!hasBeenPulled(in)) pull(in)
+ decider(cause) match {
+ case Supervision.Stop =>
+ cancelStage(cause)
+ case Supervision.Resume =>
+ if (isClosed(in)) cancelStage(cause)
+ else {
+ // Start draining
+ if (!hasBeenPulled(in)) pull(in)
+ }
+ case Supervision.Restart =>
+ if (isClosed(in)) completeStage()
+ else {
+ restartState()
+ // Start draining
+ if (!hasBeenPulled(in)) pull(in)
+ }
Review Comment:
@He-Pin Is it fine to resolve this conversation? I think the issue you point
out was specific to https://github.com/apache/incubator-pekko/issues/980 and
not about this feature in general?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
