Ghurtchu opened a new issue, #1311:
URL: https://github.com/apache/pekko/issues/1311

   I was following the online tutorial on the official `Pekko` website: 
https://pekko.apache.org/docs/pekko/current/typed/guide/tutorial_4.html#:~:text=Keeping%20track%20of,%C2%B6
   
   and I found that `DeviceTerminated.groupId` may not match with 
`DeviceGroup.groupId` but we don't handle such a case right now. I suggest that 
we keep consistency such an approach is already used with `RequestTrackDevice` 
message when `grId != groupId` and add a new case in the end to log the warning 
about the possible scenario:
   ```scala
   
https://pekko.apache.org/docs/pekko/current/typed/guide/tutorial_4.html#:~:text=Keeping%20track%20of,%C2%B6
   case DeviceTerminated(_, grId, deviceId) =>
       context.log.warnN("Ignoring DeviceTerminated for groupId:{} and 
deviceId:{}. This actor is responsible for {}", grId, deviceId, groupId)
       this
   ```
   
   
   
https://github.com/apache/pekko/blob/58fa510455190bd62d04f92a83c9506a7588d29c/docs/src/test/scala/typed/tutorial_4/DeviceGroup.scala#L85


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to