pjfanning commented on code in PR #1336:
URL: https://github.com/apache/pekko/pull/1336#discussion_r1629511989
##########
persistence-typed-tests/src/test/scala/org/apache/pekko/persistence/typed/scaladsl/EventSourcedStashOverflowSpec.scala:
##########
@@ -55,10 +55,11 @@ object EventSourcedStashOverflowSpec {
SteppingInmemJournal.config("EventSourcedStashOverflow").withFallback(ConfigFactory.parseString(s"""
pekko.persistence {
typed {
- stash-capacity = 1000 # enough to fail on stack size
+ stash-capacity = 2000 # enough to fail on stack size
Review Comment:
The idea is to have a test that someone can use to produce a fix. This
config is for one test. It is not a change to our default config.
There are some ideas for fixes in
https://github.com/apache/pekko/issues/1327.
* possibly limit the number of read-only events that can be stashed
* possibly make the unstash asynchronous or at least go async after a
recursion limit is reached
* possibly try to doing the unstashing in a loop instead of recursing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
