Roiocam commented on code in PR #1385:
URL: https://github.com/apache/pekko/pull/1385#discussion_r1663554394
##########
actor/src/main/scala/org/apache/pekko/actor/ActorCell.scala:
##########
@@ -643,7 +643,7 @@ private[pekko] class ActorCell(
def failActor(): Unit =
if (_actor != null) {
clearActorFields(actor, recreate = false)
- setFailedFatally()
+ setFailed(actor.self)
Review Comment:
After investigation, we can not set the fault state here... otherwise, we
can distinguish between fatal and normal fault
##########
actor/src/main/scala/org/apache/pekko/actor/ActorCell.scala:
##########
@@ -643,7 +643,7 @@ private[pekko] class ActorCell(
def failActor(): Unit =
if (_actor != null) {
clearActorFields(actor, recreate = false)
- setFailedFatally()
+ setFailed(actor.self)
Review Comment:
After investigation, we can not set the fault state here... otherwise, we
can not distinguish between fatal and normal fault
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
