raboof commented on code in PR #1206: URL: https://github.com/apache/pekko/pull/1206#discussion_r1695374535
########## .idea/vcs.xml: ########## @@ -0,0 +1,20 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project version="4"> + <component name="IssueNavigationConfiguration"> + <option name="links"> + <list> + <IssueNavigationLink> + <option name="issueRegexp" value="(?!\()#(\d+)(?!\))" /> + <option name="linkRegexp" value=" https://github.com/apache/incubator-pekko/issues/$1"; /> + </IssueNavigationLink> + <IssueNavigationLink> + <option name="issueRegexp" value="\(#(\d+)\)" /> + <option name="linkRegexp" value=" https://github.com/apache/incubator-pekko/pull/$1"; /> Review Comment: ```suggestion <option name="linkRegexp" value="https://github.com/apache/pekko/pull/$1"; /> ``` ########## .idea/vcs.xml: ########## @@ -0,0 +1,20 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project version="4"> + <component name="IssueNavigationConfiguration"> + <option name="links"> + <list> + <IssueNavigationLink> + <option name="issueRegexp" value="(?!\()#(\d+)(?!\))" /> + <option name="linkRegexp" value=" https://github.com/apache/incubator-pekko/issues/$1"; /> Review Comment: I guess this can drop the `incubator-` prefix and the leading space. While this will produce incorrect links when it's actually Akka issues that are referenced, that seems fine to me - those should probably either be removed or eventually become full URLs anyway. ```suggestion <option name="linkRegexp" value="https://github.com/apache/pekko/issues/$1"; /> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
