Philippus commented on code in PR #293:
URL: https://github.com/apache/pekko-management/pull/293#discussion_r1733826985
##########
management/src/main/scala/org/apache/pekko/management/internal/HealthChecksImpl.scala:
##########
@@ -47,13 +48,29 @@ final private[pekko] class HealthChecksImpl(system:
ExtendedActorSystem, setting
private val log = Logging.withMarker(system, classOf[HealthChecksImpl])
+ log.info(
+ "Loading startup checks [{}]",
+ settings.startupChecks.map(a => a.name ->
a.fullyQualifiedClassName).mkString(", "))
log.info(
"Loading readiness checks [{}]",
settings.readinessChecks.map(a => a.name ->
a.fullyQualifiedClassName).mkString(", "))
log.info(
"Loading liveness checks [{}]",
settings.livenessChecks.map(a => a.name ->
a.fullyQualifiedClassName).mkString(", "))
+ private val startupness: immutable.Seq[HealthCheck] = {
Review Comment:
yes, I was struggling with that name, because `startup` is already taken.
`startupChecks` is also used in the settings, but indeed doesn't clash
otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
