mdedetrich commented on code in PR #876:
URL: https://github.com/apache/pekko-connectors/pull/876#discussion_r1814822873
##########
google-fcm/src/test/scala/org/apache/pekko/stream/connectors/google/firebase/fcm/v1/impl/FcmSenderSpec.scala:
##########
@@ -83,7 +83,7 @@ class FcmSenderSpec
val request: HttpRequest = captor.getValue
Unmarshal(request.entity).to[FcmSend].futureValue shouldBe
FcmSend(false, FcmNotification.empty)
request.uri.toString should
startWith("https://fcm.googleapis.com/v1/projects/projectId/messages:send";)
- request.headers.size shouldBe 1
+ request.headers.size shouldBe 2
Review Comment:
Since we have added an extra keep alive header we know return 2 headers, but
we still only check the first header for what we expect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
