pjfanning commented on issue #158: URL: https://github.com/apache/pekko-persistence-r2dbc/issues/158#issuecomment-2477270989
> @pjfanning There is an issue with keeping backwards compatibility while implementing projection support for MySQL - [R2dbcProjectionSettings](https://github.com/apache/pekko-persistence-r2dbc/blob/main/projection/src/main/scala/org/apache/pekko/projection/r2dbc/R2dbcProjectionSettings.scala). This class needs a new attribute for `dialect`, and since it is a `case class` there is no way to not break it. Is it okay to break backwards compatibility and convert this to a class, or do you see a different way to proceed? Could you add a 2nd constructor to the case class that has the legacy param list and that calls the changed main constructor, setting a sensible default on the new params? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
