pjfanning commented on code in PR #177: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/177#discussion_r1848847389
########## projection/src/main/scala/org/apache/pekko/projection/r2dbc/R2dbcProjectionSettings.scala: ########## Review Comment: I see the TODO on the class - so I don't mind a rewrite for 1.1.0. It would still be nice to minimise source incompatible changes - i.e. code with against 1.0.0 would ideally still be compilable with 1.1.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
