sadekmunawar commented on PR #1567: URL: https://github.com/apache/pekko/pull/1567#issuecomment-2530072685
@pjfanning There two missing pieces left: 1. Deserialization of Akka cluster messages. I created the PR for this one #1578 2. Supporting Akka config for JoinConfigCompatChecker. An exception is thrown [here](https://github.com/apache/pekko/blob/main/cluster/src/main/scala/org/apache/pekko/cluster/JoinConfigCompatCheckCluster.scala#L40-L42), when a Pekko node tries to find the downing path in the Akka config. I solved it by simply checking if the path exists in the config before doing the comparison. ``` val downingProviderResult = { if (toCheck.hasPath(DowningProviderPath) && actualConfig.hasPath(DowningProviderPath)) JoinConfigCompatChecker.checkEquality(List(DowningProviderPath), toCheck, actualConfig) else Invalid(im.Seq("Downing path not found. Set configuration-compatibility-check.enforce-on-join to off to enable cluster joining.")) } ``` While this all that's necessary for the rolling upgrade support, I tried to find a better approach for the second problem. See this [commit](https://github.com/sadekmunawar/pekko/commit/60f208f7c9690c98356466094ec97516cc0f8230). I haven't had the chance to integration test this approach, yet. It should fix the exception issue, but it likely sends configs with Pekko paths to Akka nodes [here](https://github.com/sadekmunawar/pekko/commit/60f208f7c9690c98356466094ec97516cc0f8230#diff-93928721f2ceeb4acf73b9c1582977f8c1157feefbf64e6d5f8a694e5ae40a5aR647-R654) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
