pjfanning commented on PR #907: URL: https://github.com/apache/pekko-connectors/pull/907#issuecomment-2545105689
@raboof @He-Pin @Roiocam I'm tempted to merge this. We already have merged amazon-kinesis-client:3.0.1 and this also brings in a Protobuf-Java v4 dependency. This PR doesn't break any unit tests. From what I've read Protobuf-Java v4 is expected to work in almost all cases where the original libs that use it were compiled with comparatively recent Protobuf-Java v3 dependencies. It just seems more complicated to have to analyse every Scala Steward PR to see if it might contain a transitive dependency on Protobuf-Java v4. It's easier to rely on the build and tests to see if the PR breaks anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
