raboof commented on code in PR #320:
URL: https://github.com/apache/pekko-management/pull/320#discussion_r2060340693


##########
management/src/main/scala/org/apache/pekko/management/HealthCheckRoutes.scala:
##########
@@ -66,3 +71,17 @@ private[pekko] class HealthCheckRoutes(system: 
ExtendedActorSystem) extends Mana
       })
   }
 }
+
+/**
+ * Providing an extension, so users can get the routes and add it to their own 
server
+ * @since 1.1.0
+ */
+object HealthCheckRoutes extends ExtensionId[HealthCheckRoutes] with 
ExtensionIdProvider {
+  override def get(system: ActorSystem): HealthCheckRoutes = super.get(system)

Review Comment:
   returning it here means `HealthCheckRoutes` is becoming public API, so we 
should remove the 'internal' markers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to