He-Pin commented on code in PR #1841:
URL: https://github.com/apache/pekko/pull/1841#discussion_r2081681714
##########
stream/src/main/scala/org/apache/pekko/stream/scaladsl/Hub.scala:
##########
@@ -476,7 +476,8 @@ object BroadcastHub {
/**
* INTERNAL API
*/
-private[pekko] class BroadcastHub[T](startAfterNrOfConsumers: Int, bufferSize:
Int)
+private[pekko] class BroadcastHub[T](startAfterNrOfConsumers: Int, bufferSize:
Int,
+ registrationPendingCallback: Long => Unit = _ => ())
Review Comment:
1. Add a doc about the `registrationPendingCallback` function input and
expected output?
2. Avoid using the default parameter , add an overloaded constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
