pjfanning commented on code in PR #220:
URL: 
https://github.com/apache/pekko-persistence-r2dbc/pull/220#discussion_r2160486655


##########
docs/src/main/paradox/release-notes/releases-1.2.md:
##########
@@ -0,0 +1,14 @@
+# Release Notes (1.2.x)
+
+Apache Pekko Persistence R2DBC 1.1.x releases support Java 8 and above.
+
+## 1.2.0
+
+Release notes for Apache Pekko Persistence R2DBC 1.2.0.
+
+### Breaking Changes
+
+* Configuring persistence plugins at runtime 
([PR194](https://github.com/apache/pekko-persistence-r2dbc/pull/194))
+  * We removed implicit merging of specific plugin configuration 
(`pekko.persistence.r2dbc.journal`, `pekko.persistence.r2dbc.snapshot`, etc.) 
with shared configuration (`pekko.persistence.r2dbc`) upon plugin 
initialization, which means that specific plugin configurations must refer to 
shared keys explicitly.

Review Comment:
   my vague recollection is that 2 spaces is not the right spacing to get this 
to appear correctly (as nested bullet points) - my very vague recollection is 
that it is 4 but building the docs will verify this either way



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org

Reply via email to