pjfanning commented on code in PR #194:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/194#discussion_r2161547970
##########
core/src/test/scala/org/apache/pekko/persistence/r2dbc/TestConfig.scala:
##########
@@ -61,26 +61,24 @@ object TestConfig {
""")
}
- // using load here so that connection-factory can be overridden
- ConfigFactory.load(dialectConfig.withFallback(ConfigFactory.parseString("""
+ dialectConfig.withFallback(ConfigFactory.parseString("""
pekko.loglevel = DEBUG
pekko.persistence.journal.plugin = "pekko.persistence.r2dbc.journal"
pekko.persistence.snapshot-store.plugin =
"pekko.persistence.r2dbc.snapshot"
pekko.persistence.state.plugin = "pekko.persistence.r2dbc.state"
- pekko.persistence.r2dbc {
- query {
- refresh-interval = 1s
- }
- }
+ pekko.persistence.r2dbc.refresh-interval = 1s
pekko.actor {
serialization-bindings {
"org.apache.pekko.persistence.r2dbc.CborSerializable" = jackson-cbor
}
}
pekko.actor.testkit.typed.default-timeout = 10s
- """)))
+ """))
}
+ // FIXME ideally every dependant that combines this config with other
configs should load/resolve at their callsites
Review Comment:
can you raise an issue with any unresolved todos or fixmes and put the URL
of the issue in the comment here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
