sbmpost commented on PR #1152: URL: https://github.com/apache/pekko-connectors/pull/1152#issuecomment-3245625614
@pjfanning Link: https://docs.oasis-open.org/mqtt/mqtt/v3.1.1/os/mqtt-v3.1.1-os.html#_Toc398718022 shows the reserved bits for UnsubAck and PingReq: SUBACK | Reserved | 0 | 0 | 0 | 0 PINGREQ | Reserved | 0 | 0 | 0 | 0 Both the same value. However the code as is, uses UnsubAckReserved for UnsubAck and ReservedGeneral for PingReq which doesn't make sense. When I created issue https://github.com/akka/alpakka/issues/2963, I pointed out exactly how and where in the code to fix this. So if there is any copyright involved, it would be mine and I am sharing it now with Pekko. Link: https://docs.oasis-open.org/mqtt/mqtt/v3.1.1/os/mqtt-v3.1.1-os.html#_Toc385349311 shows the lower two bits of the Subscribe message are to be used for QoS service: x x x x x x q q The code however assumes the ControlPacketFlags for QoS are: x x x x x q q x which is correct for the Publish message, but not for the Subscribe message For this one there is issue https://github.com/akka/alpakka/issues/2731, in which I explained how the bit shift is required for the Subscribe message. The Alpakka developers decided to fix this differently, so I am quite sure this fix is OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
