pjfanning commented on PR #2161: URL: https://github.com/apache/pekko/pull/2161#issuecomment-3262295062
I suppose this is ok. #2160 makes no mention that you intended to just use ReentrantLock directly. ReentrantGuard seems/seemed useful as it was hard to forget to unlock in the lock in every case. The new code looks correct but every time someone uses ReentrantGuard directly, we need to very closely examine the code to ensure the try/finally code is implemented correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
