mdedetrich commented on PR #2156: URL: https://github.com/apache/pekko/pull/2156#issuecomment-3261738637
> @mdedetrich You can give it a try, this code will work ok if the event loop is a virtual thread; otherwise, dead deadlock. [netty/netty#15405](https://github.com/netty/netty/discussions/15405) I know that it won't block if you use a `VirtualThread` but we cannot force people to use `VirtualThread` so if it blocks on standard usage (which it does) then its as unsafe as the other stream converters and for this reason you need to follow the same pattern, i.e. only give the reference to a Java 1.8 Stream as a final value in a `Sink` otherwise people will almost always deadlock themselves when using the API. There is a reason why the current StreamCoverters are designed the way they are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
