pjfanning commented on code in PR #784:
URL: https://github.com/apache/pekko-http/pull/784#discussion_r2356514983
##########
http-core/src/main/java/org/apache/pekko/http/javadsl/TimeoutAccess.java:
##########
@@ -34,17 +33,31 @@ public interface TimeoutAccess {
* <p>Due to the inherent raciness it is not guaranteed that the returned
timeout was applied
* before the previously set timeout has expired!
*/
- Duration getTimeout();
+ scala.concurrent.duration.Duration getTimeout();
Review Comment:
I intend to break this API in a later commit. This is just a forward fit of
#780. For traceability, I want to add those changes in one PR and do another PR
with the 2.0.0 breaking changes.
This API method isn't changing in this PR, I just fully referenced
scala.concurrent.duration.Duration to make it more obvious that that was class
that was being returned.
In my follow up PR, I will change the return type to java.time.Duration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
