raboof commented on code in PR #1205:
URL: https://github.com/apache/pekko-connectors/pull/1205#discussion_r2362517044
##########
sse/src/main/scala/org/apache/pekko/stream/connectors/sse/scaladsl/EventSource.scala:
##########
@@ -111,7 +113,12 @@ object EventSource {
.flatMap(Unmarshal(_).to[EventSource])
.fallbackTo(Future.successful(noEvents))
}
- def recover(eventSource: EventSource) =
eventSource.recoverWithRetries(1, { case _ => noEvents })
+ def recover(eventSource: EventSource) = eventSource.recoverWithRetries(1,
+ {
+ case e =>
+ log.warning(e, "SSE Connector is retrying failed stream for: {} ",
uri)
Review Comment:
I agree it seems sensible to log something. I'm not sure it makes sense to
log at the `warning` level, because I suspect the stream could fail for reasons
outside the control of the operator (e.g. upstream/downstream disconnects),
might be better at `info`?
```suggestion
log.warning(e, "SSE Connector is retrying failed stream for:
{}", uri)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
