raboof commented on PR #759: URL: https://github.com/apache/pekko-http/pull/759#issuecomment-3279619959
> @raboof we could just remove all of this in 2.0.0. We have a 1.3.x branch and a future 1.3.0 where we can deprecate any extra methods that needs to be deprecated. The thing is though that we have tests that rely on withRemoteAddressHeader and that don't pass if you use withRemoteAddressAttribute instead. That's the piece that is blocking this. I think that's a test that explicitly tested the deprecated behavior still worked. I think we can remove the test (or rework it to use attributes instead) when removing the deprecated functionality. https://github.com/apache/pekko-http/blob/main/http-core/src/test/scala/org/apache/pekko/http/scaladsl/ClientServerSpec.scala#L195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
