pjfanning commented on code in PR #2251:
URL: https://github.com/apache/pekko/pull/2251#discussion_r2366045478
##########
stream/src/main/scala/org/apache/pekko/stream/impl/PhasedFusingActorMaterializer.scala:
##########
@@ -60,7 +60,7 @@ import org.reactivestreams.Subscriber
*/
@InternalApi private[pekko] object PhasedFusingActorMaterializer {
- val Debug = false
+ final val Debug = false
Review Comment:
Aren't Scala objects essentially final classes - in that they can't be
extended ?
If a class is final then its fields are basically final too.
Is there really a benefit to marking a val in an object as final?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
